Implement VPN control through UDS #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r more than just the VPN
diegoreymendez
changed the base branch from
main
to
diego/app-launcher-code-cleanup
samsymons
reviewed
Jun 12, 2024
samsymons
reviewed
Jun 12, 2024
samsymons
reviewed
Jun 12, 2024
LocalPackages/UDSHelper/Tests/UDSHelperTests/UDSHelperTests.swift
Outdated
Show resolved
Hide resolved
|
Added a few comments, but the testing instructions all worked for me 👏 |
Co-authored-by: Sam Symons <[email protected]>
|
All feedback is addressed, can I ask for another look? |
|
Sorry, realized that I had missed some comments... it should be good now. I'll be testing some more, meanwhile. |
samsymons
approved these changes
Jun 12, 2024
quanganhdo
approved these changes
Jun 12, 2024
samsymons
added a commit
that referenced
this pull request
Jun 12, 2024
# By Sam Symons (8) and others # Via GitHub * main: (35 commits) Check DBP Prerequisites in App and Disable Login Item If Necessary (#2850) Fixes an issue with my last merge Implement VPN control through UDS (#2767) Add VPN reddit cookie workaround (#2851) Bump version to 1.92.0 (202) Update Send Feedback icon (#2852) Make passwords easier to discover (#2847) Bump version to 1.92.0 (201) Update BSK for RMF survey changes (#2846) DBP: Update people-wizard.com (#2849) Remove VPN launch pixels (#2845) Prevent showing multiple VPN uninstalled popovers (#2844) Bump version to 1.92.0 (200) Set marketing version to 1.92.0 Update embedded files DBP: Implement stats pixels (#2812) DBP: Add support for noResultsSelector (#2840) Fire compilation failed pixel if needed (#1626) Update autoconsent to v10.10.0 (#2842) Fix running Autofill-related UI tests in CI (#2843) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203108348835387/1207203883170230/f
Description
Implement VPN control through UDS
Testing
Test 1:
Test 2:
Test 3:
launchctl remove <agent>Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation